linux-kernel - Re: [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a385c2e6fc133a9d93bded92a946e4f@protonic.nl>
Date:   Thu, 30 Sep 2021 08:37:35 +0200
From:   Robin van der Gracht <robin@...tonic.nl>
To:     Mianhan Liu <liumh1@...nghaitech.edu.cn>
Cc:     Miguel Ojeda <ojeda@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous
 header files from ht16k33.c

On 2021-09-28 21:15, Mianhan Liu wrote:
> ht16k33.c hasn't use any macro or function declared in linux/slab.h.
> Thus, these files can be removed from ht16k33.c safely without
> affecting the compilation of the drivers/auxdisplay/ module
> 
> Signed-off-by: Mianhan Liu <liumh1@...nghaitech.edu.cn>
> 
> ---
>  drivers/auxdisplay/ht16k33.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
> index 1e69cc6d2..6502bc00e 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -13,7 +13,6 @@
>  #include <linux/i2c.h>
>  #include <linux/of.h>
>  #include <linux/fb.h>
> -#include <linux/slab.h>
>  #include <linux/backlight.h>
>  #include <linux/input.h>
>  #include <linux/input/matrix_keypad.h>

Acked-by: Robin van der Gracht <robin@...tonic.nl>