linux-kernel - Re: [l1k:nft_egress_v5 4/5] net/netfilter/nfnetlink_hook.c:232:17: error: 'netdev' undeclared; did you mean 'net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210930071333.GB28709@wunner.de>
Date:   Thu, 30 Sep 2021 09:13:33 +0200
From:   Lukas Wunner <lukas@...ner.de>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [l1k:nft_egress_v5 4/5] net/netfilter/nfnetlink_hook.c:232:17:
 error: 'netdev' undeclared; did you mean 'net_eq'?

On Thu, Sep 30, 2021 at 02:39:37PM +0800, kernel test robot wrote:
>    net/netfilter/nfnetlink_hook.c: In function 'nfnl_hook_entries_head':
> >> net/netfilter/nfnetlink_hook.c:232:17: error: 'netdev' undeclared (first use in this function); did you mean 'net_eq'?
>      232 |                 netdev = dev_get_by_name_rcu(net, dev);
>          |                 ^~~~~~
>          |                 net_eq
>    net/netfilter/nfnetlink_hook.c:232:17: note: each undeclared identifier is reported only once for each function it appears in

Thank you, trusty robot.  I've just fixed up the branch as follows:


diff --git a/net/netfilter/nfnetlink_hook.c b/net/netfilter/nfnetlink_hook.c
index 782d2db..c1559e8 100644
--- a/net/netfilter/nfnetlink_hook.c
+++ b/net/netfilter/nfnetlink_hook.c
@@ -185,7 +185,7 @@ static int nfnl_hook_dump_one(struct sk_buff *nlskb,
 nfnl_hook_entries_head(u8 pf, unsigned int hook, struct net *net, const char *dev)
 {
 	const struct nf_hook_entries *hook_head = NULL;
-#ifdef CONFIG_NETFILTER_INGRESS
+#if defined(CONFIG_NETFILTER_INGRESS) || defined(CONFIG_NETFILTER_EGRESS)
 	struct net_device *netdev;
 #endif