linux-kernel - Re: [PATCH v7 12/15] KVM: arm64: selftests: Add basic GICv3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab2a7213-1857-6761-594d-958af864a23a@huawei.com>
Date:   Thu, 30 Sep 2021 16:06:31 +0800
From:   Zenghui Yu <yuzenghui@...wei.com>
To:     Raghavendra Rao Ananta <rananta@...gle.com>
CC:     Paolo Bonzini <pbonzini@...hat.com>, Marc Zyngier <maz@...nel.org>,
        "Andrew Jones" <drjones@...hat.com>,
        James Morse <james.morse@....com>,
        "Alexandru Elisei" <alexandru.elisei@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        <kvm@...r.kernel.org>, Catalin Marinas <catalin.marinas@....com>,
        Peter Shier <pshier@...gle.com>,
        <linux-kernel@...r.kernel.org>, Will Deacon <will@...nel.org>,
        <kvmarm@...ts.cs.columbia.edu>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v7 12/15] KVM: arm64: selftests: Add basic GICv3 support

On 2021/9/15 6:31, Raghavendra Rao Ananta wrote:
> +static inline void *gicr_base_gpa_cpu(void *redist_base, uint32_t cpu)
> +{
> +	/* Align all the redistributors sequentially */
> +	return redist_base + cpu * SZ_64K * 2;
> +}
> +
> +static void gicv3_cpu_init(unsigned int cpu, void *redist_base)
> +{
> +	void *sgi_base;
> +	unsigned int i;
> +	void *redist_base_cpu;
> +
> +	GUEST_ASSERT(cpu < gicv3_data.nr_cpus);
> +
> +	redist_base_cpu = gicr_base_gpa_cpu(redist_base, cpu);

This is not 'gpa' and I'd rather open-code it directly as there's
just a single caller.

Zenghui