linux-kernel - Re: [PATCH] mm: remove useless lines in enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Sep 2021 10:22:14 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Shi Lei <shi_lei@...sclouds.com>, cl@...ux.com, penberg@...nel.org,
        rientjes@...gle.com, iamjoonsoo.kim@....com,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: remove useless lines in enable_cpucache()

On 9/30/21 05:48, Shi Lei wrote:
> These lines are useless, so remove them.

I would clarify that they are useless after commit 10befea91b61 ("mm:
memcg/slab: use a single set of kmem_caches for all allocations")



> Signed-off-by: Shi Lei <shi_lei@...sclouds.com>

Reviewed-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>  mm/slab.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index 4d826394ffcb..01775fe0e002 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3900,8 +3900,6 @@ static int enable_cpucache(struct kmem_cache *cachep, gfp_t gfp)
>  	if (err)
>  		goto end;
>  
> -	if (limit && shared && batchcount)
> -		goto skip_setup;
>  	/*
>  	 * The head array serves three purposes:
>  	 * - create a LIFO ordering, i.e. return objects that are cache-warm
> @@ -3944,7 +3942,6 @@ static int enable_cpucache(struct kmem_cache *cachep, gfp_t gfp)
>  		limit = 32;
>  #endif
>  	batchcount = (limit + 1) / 2;
> -skip_setup:
>  	err = do_tune_cpucache(cachep, limit, batchcount, shared, gfp);
>  end:
>  	if (err)
>