linux-kernel - Re: [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8d40be8-045c-096a-f079-d9f6364254e9@foss.st.com>
Date:   Thu, 30 Sep 2021 10:47:50 +0200
From:   Alexandre TORGUE <alexandre.torgue@...s.st.com>
To:     Marek Vasut <marex@...x.de>,
        Olivier Moysan <olivier.moysan@...s.st.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Rob Herring <robh+dt@...nel.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on
 stm32mp15

Hi Marek

On 9/29/21 1:18 PM, Marek Vasut wrote:
> On 9/27/21 1:45 PM, Olivier Moysan wrote:
>> Fix SAI2B pin muxing for AV96 board on STM32MP15.
>> The label "sai2a-4" is defined twice. Change redundant label to 
>> "sai2b-4".
>>
>> Fixes: dcf185ca8175 ("ARM: dts: stm32: Add alternate pinmux for SAI2 
>> pins on stm32mp15")
>>
>> Signed-off-by: Olivier Moysan <olivier.moysan@...s.st.com>
>> ---
>>   arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi 
>> b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>> index 5b60ecbd718f..b9cc9e0dd4fc 100644
>> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>> @@ -1235,7 +1235,7 @@
>>           };
>>       };
>> -    sai2b_pins_c: sai2a-4 {
>> +    sai2b_pins_c: sai2b-4 {
>>           pins1 {
>>               pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */
>>               bias-disable;
> 
> This mp1 pinmuxing is a total mess, sigh.

What is the issue here ?

> Can you please also fix sai1a-4 and sai1a-5, which should really be 
> sai1a-2 and sai1a-sleep-2 ? Same as the sai2b-4 and sai2b-5 should be 
> sai2b-2 and sai2b-sleep-2 .
> 
> With that, it would be perfect, thank you.
> 
> [...]