linux-kernel - Re: [PATCH] r8152: stop submitting rx for -EPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <274ec862-86cf-9d83-7ea7-5786e30ca4a7@suse.com>
Date:   Thu, 30 Sep 2021 11:30:17 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Jason-ch Chen <jason-ch.chen@...iatek.com>,
        Hayes Wang <hayeswang@...ltek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "Project_Global_Chrome_Upstream_Group@...iatek.com" 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...gle.com" <hsinyi@...gle.com>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: Re: [PATCH] r8152: stop submitting rx for -EPROTO


On 29.09.21 11:52, Jason-ch Chen wrote:
> On Wed, 2021-09-29 at 08:14 +0000, Hayes Wang wrote:
>>
> Hi Hayes,
>
> Sometimes Rx submits rapidly and the USB kernel driver of opensource
> cannot receive any disconnect event due to CPU heavy loading, which
> finally causes a system crash.
> Do you have any suggestions to modify the r8152 driver to prevent this
> situation happened?
>
> Regards,
> Jason
>
Hi,

Hayes proposed a solution. Basically you solve this the way HID or WDM do it
delaying resubmission. This makes me wonder whether this problem is specific
to any driver. If it is not, as I would argue, do we have a deficiency
in our API?

Should we have something like: usb_submit_delayed_urb() ?

    Regards
        Oliver