linux-kernel - Re: [PATCH 1/2] PCI: Use software node API with additional device properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gAfWaUXjMrSf7Ei-P=0u7kzHVKQNFY0aSxs6KFd5T6ow@mail.gmail.com>
Date:   Thu, 30 Sep 2021 12:37:27 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-pci <linux-pci@...r.kernel.org>
Subject: Re: [PATCH 1/2] PCI: Use software node API with additional device properties

On Thu, Sep 30, 2021 at 12:20 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Thu, Sep 30, 2021 at 1:06 PM Heikki Krogerus
> <heikki.krogerus@...ux.intel.com> wrote:
> > On Thu, Sep 30, 2021 at 10:33:27AM +0800, Zhangfei Gao wrote:
>
> ...
>
> > If the device is really never removed, then we could also constify the
> > node and the properties in it. Then the patch would look like this:
>
> I'm not sure the user can't force removal of the device (via PCI
> rescan, for example,, or via unbind/bind cycle).

The sysfs unbind doesn't remove the device, though, AFAICS.  It just
unbinds the driver from it, if any.

> I guess this way should be really taken carefully.

But I agree.