linux-kernel - Re: [PATCH v1 2/2] mmc: slot-gpio: Update default label when no con

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFr+Y-fjKvjOg_W=+hHPABTHdApZ8=WWwXn6gQy0tn6+bQ@mail.gmail.com>
Date:   Thu, 30 Sep 2021 13:24:54 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/2] mmc: slot-gpio: Update default label when no
 con_id provided

On Wed, 29 Sept 2021 at 13:17, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Currently default label of GPIO is assigned to the device name,
> when no con_id provided. Instead, let's update it to reflect
> what it's about (use already prepared template).
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/slot-gpio.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/core/slot-gpio.c
> index e365d328f43c..dd2a4b6ab6ad 100644
> --- a/drivers/mmc/core/slot-gpio.c
> +++ b/drivers/mmc/core/slot-gpio.c
> @@ -178,6 +178,10 @@ int mmc_gpiod_request_cd(struct mmc_host *host, const char *con_id,
>         if (IS_ERR(desc))
>                 return PTR_ERR(desc);
>
> +       /* Update default label if no con_id provided */
> +       if (!con_id)
> +               gpiod_set_consumer_name(desc, ctx->cd_label);
> +
>         if (debounce) {
>                 ret = gpiod_set_debounce(desc, debounce);
>                 if (ret < 0)
> @@ -226,6 +230,10 @@ int mmc_gpiod_request_ro(struct mmc_host *host, const char *con_id,
>         if (IS_ERR(desc))
>                 return PTR_ERR(desc);
>
> +       /* Update default label if no con_id provided */
> +       if (!con_id)
> +               gpiod_set_consumer_name(desc, ctx->ro_label);
> +
>         if (debounce) {
>                 ret = gpiod_set_debounce(desc, debounce);
>                 if (ret < 0)
> --
> 2.33.0
>