linux-kernel - Re: [PATCH] scsi: acornscsi: Remove scsi_cmd_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1ytv5okZZhdGYfecLkO+WPQESdDibtu5io5+nB6jygqQ@mail.gmail.com>
Date:   Thu, 30 Sep 2021 14:10:53 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     John Garry <john.garry@...wei.com>
Cc:     Russell King - ARM Linux <linux@...linux.org.uk>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Hannes Reinecke <hare@...e.de>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] scsi: acornscsi: Remove scsi_cmd_to_tag() reference

On Thu, Sep 30, 2021 at 1:51 PM John Garry <john.garry@...wei.com> wrote:
>
> Commit 756fb6a895afb ("scsi: acornscsi: Remove tagged queuing vestiges")
> mistakenly introduced a reference to function scsi_cmd_to_tag(). This
> function does not exist as it was removed from an earlier series version
> when I upstreamed the named commit - originally authored By Hannes - but
> this reference still remained.
>
> Fix by replacing the reference to scsi_cmd_to_tag() with
> scsi_cmd_to_rq(scsi_scmd)->tag, which scsi_cmd_to_tag() was a wrapper for.
>
> Fixes: 756fb6a895afb ("scsi: acornscsi: Remove tagged queuing vestiges")
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: John Garry <john.garry@...wei.com>

Thanks, that fixes the build regression and looks sensible.

Tested-by: Arnd Bergmann <arnd@...db.de>