linux-kernel - Re: [PATCH v4 0/2] Fix simple-bus issues with fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB70812E56DB9CB8CDC63C6535E7AA9@DM6PR04MB7081.namprd04.prod.outlook.com>
Date:   Thu, 30 Sep 2021 02:50:15 +0000
From:   Damien Le Moal <Damien.LeMoal@....com>
To:     Saravana Kannan <saravanak@...gle.com>,
        Russell King <linux@...linux.org.uk>,
        Neil Armstrong <narmstrong@...libre.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "kernel-team@...roid.com" <kernel-team@...roid.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-oxnas@...ups.io" <linux-oxnas@...ups.io>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v4 0/2] Fix simple-bus issues with fw_devlink

On 2021/09/29 9:07, Saravana Kannan wrote:
> Ulf reported an issue[1] with fw_devlink. This series tries to fix that
> issue.
> 
> I replicated a similar set up on my end and I confirmed:
> - A simple-bus only device is probed.
> - Another device listing simple-bus as a 2nd compatible string isn't
>   probed.
> 
> v1->v2:
> - Switched to probing the simple-bus device instead of marking it as
>   NEVER_PROBES.
> 
> v2->v3:
> - Moved all the code into the simple-pm-bus driver
> - Addressed Ulf's comment about the remove() code missing a check.
> 
> v3->v4:
> - Added support for driver_override to accommodate the case where new
>   transparent bus compatible strings are added to DT, but the kernel hasn't
>   been updated yet.
> - Added/updated comments to give more details.
> - Adding Ulf's Tested-by that he have for v3 (v4 didn't change by much).

For riscv Kendryte K210 boards:

Tested-by: Damien Le Moal <damien.lemoal@....com>

> 
> Thanks,
> Saravana
> [1] - https://lore.kernel.org/lkml/CAPDyKFo9Bxremkb1dDrr4OcXSpE0keVze94Cm=zrkOVxHHxBmQ@mail.gmail.com/
> 
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: Rob Herring <robh+dt@...nel.org>
> 
> Saravana Kannan (2):
>   drivers: bus: simple-pm-bus: Add support for probing simple bus only
>     devices
>   drivers: bus: Delete CONFIG_SIMPLE_PM_BUS
> 
>  arch/arm/configs/multi_v7_defconfig |  1 -
>  arch/arm/configs/oxnas_v6_defconfig |  1 -
>  arch/arm/configs/shmobile_defconfig |  1 -
>  arch/arm/mach-omap2/Kconfig         |  1 -
>  arch/arm64/configs/defconfig        |  1 -
>  drivers/bus/Kconfig                 | 12 ---------
>  drivers/bus/Makefile                |  2 +-
>  drivers/bus/simple-pm-bus.c         | 42 ++++++++++++++++++++++++++---
>  drivers/soc/canaan/Kconfig          |  1 -
>  9 files changed, 40 insertions(+), 22 deletions(-)
> 


-- 
Damien Le Moal
Western Digital Research