linux-kernel - Re: [PATCH V4 19/22] LoongArch: Add VDSO and VSYSCALL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6fc1fa8bf4decf97d76900a64fe0bc2bf25576d.camel@mengyan1223.wang>
Date:   Thu, 30 Sep 2021 23:43:41 +0800
From:   Xi Ruoyao <xry111@...gyan1223.wang>
To:     Huacai Chen <chenhuacai@...ngson.cn>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-arch@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Huacai Chen <chenhuacai@...il.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH V4 19/22] LoongArch: Add VDSO and VSYSCALL support

On Mon, 2021-09-27 at 14:42 +0800, Huacai Chen wrote:
> diff --git a/arch/loongarch/vdso/gen_vdso_offsets.sh
> b/arch/loongarch/vdso/gen_vdso_offsets.sh
> new file mode 100755
> index 000000000000..7da255fea213
> --- /dev/null
> +++ b/arch/loongarch/vdso/gen_vdso_offsets.sh
> @@ -0,0 +1,14 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +
> +#
> +# Derived from RISC-V and ARM64:
> +# Author: Will Deacon <will.deacon@....com>
> +#
> +# Match symbols in the DSO that look like VDSO_*; produce a header
> file
> +# of constant offsets into the shared object.
> +#
> +
> +LC_ALL=C

I'm wondering whether this line is really useful... There is no "export"
here so the variable won't be passed to the environment of the sed
command below.

> +sed -n -e 's/^00*/0/' -e \
> +'s/^\([0-9a-fA-F]*\) . VDSO_\([a-zA-Z0-9_]*\)$/\#define
> vdso_offset_\2\t0x\1/p'