[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <07981514-563a-d64b-3fbf-ddf51e021f2c@samsung.com>
Date: Thu, 30 Sep 2021 12:36:22 +0900
From: Chanwoo Choi <cw00.choi@...sung.com>
To: Yassine Oudjana <y.oudjana@...tonmail.com>,
MyungJoo Ham <myungjoo.ham@...sung.com>,
Rob Herring <robh+dt@...nel.org>
Cc: Michael Auchter <michael.auchter@...com>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 0/3] extcon: usbc-tusb320: Initial TUSB320L support
On 9/25/21 2:45 PM, Yassine Oudjana wrote:
> The TUSB320L is a newer chip with additional features. It is close enough to TUSB320 so it works
> to some extent out-of-the-box, but for some reason it can start in UFP mode which is not desirable.
>
> This series adds support for reset and mode setting for both chips, and does that while probing
> to ensure the chip starts with the default mode of following the PORT pin.
>
> Changes since v4:
> - Use ops struct instead of type enum.
> Changes since v3:
> - Remove unused tusb_modes.
> - Remove extra blank line.
> Changes since v2:
> - Read state before setting default mode, then update it again after resetting.
> - Remove mode tracing from irq handler
> - Add a delay after reset to handle tSOFT_RESET
> - Use a separate mode setting function for each of TUSB320 and TUSB320L.
> Changes since v1:
> - Split first patch into two patches, one adding support for mode setting and reset on TUSB320,
> and the other adding support for TUSB320L.
> - Fix dt_binding_check warning:
> ../Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml:15:6: [warning] wrong indentation: expected 6 but found 5 (indentation)
>
> Yassine Oudjana (3):
> extcon: usbc-tusb320: Add support for mode setting and reset
> extcon: usbc-tusb320: Add support for TUSB320L
> dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string
>
> .../bindings/extcon/extcon-usbc-tusb320.yaml | 4 +-
> drivers/extcon/extcon-usbc-tusb320.c | 163 +++++++++++++++++-
> 2 files changed, 161 insertions(+), 6 deletions(-)
>
Thanks for fixup. Applied them.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Powered by blists - more mailing lists