linux-kernel - Re: [RFC v2 10/11] hte: Add tegra GPIO HTE test driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <466cf944-4eae-ad4c-dcf5-42e2e043b754@infradead.org>
Date:   Fri, 1 Oct 2021 16:47:38 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Dipen Patel <dipenp@...dia.com>, thierry.reding@...il.com,
        jonathanh@...dia.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-gpio@...r.kernel.org,
        linus.walleij@...aro.org, bgolaszewski@...libre.com,
        warthog618@...il.com, devicetree@...r.kernel.org,
        linux-doc@...r.kernel.org, robh+dt@...nel.org
Subject: Re: [RFC v2 10/11] hte: Add tegra GPIO HTE test driver

Hi,

On 9/30/21 4:26 PM, Dipen Patel wrote:
> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
> index eb339526f141..57c97034d187 100644
> --- a/drivers/hte/Kconfig
> +++ b/drivers/hte/Kconfig
> @@ -38,4 +38,13 @@ config HTE_TEGRA194_IRQ_TEST
>   	  The NVIDIA Tegra194 GTE IRQ test driver demonstrates HTE subsystem
>   	  usage for the LIC IRQ hardware timestamp.
>   
> +config HTE_TEGRA194_GPIO_TEST
> +        tristate "NVIDIA Tegra194 HTE GPIO Test"
> +        depends on HTE_TEGRA194
> +        help
> +	  The NVIDIA Tegra194 GTE GPIO test driver demonstrates how to use HTE

	                                                            to use the HTE

> +	  subsystem indirectly through gpiolib API calls for GPIO line for the

	                                                          lines

> +	  hardware assisted timestamping.

	  hardware-assisted

> +
>   endif

Also:

Please follow coding-style for Kconfig files:

(from Documentation/process/coding-style.rst, section 10):

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.

Some of the lines above are indented with spaces instead of one tab.


thanks.
-- 
~Randy