linux-kernel - Re: [PATCH v3 16/30] ABI: sysfs-bus-soundwire-slave: use wildcards on What definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YVaQohW0ykARCJJh@matsya>
Date:   Fri, 1 Oct 2021 10:07:54 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 16/30] ABI: sysfs-bus-soundwire-slave: use wildcards
 on What definitions

On 16-09-21, 18:47, Mauro Carvalho Chehab wrote:
> Hi Pierre,
> 
> Em Thu, 16 Sep 2021 11:36:33 -0500
> Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> escreveu:
> 
> > On 9/16/21 3:59 AM, Mauro Carvalho Chehab wrote:
> > > An "N" upper letter is not a wildcard, nor can easily be identified
> > > by script, specially since the USB sysfs define things like.
> > > bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl
> > > to convert it into a Regex.
> > > 
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>  
> > 
> > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> 
> Thanks!
> 
> > 
> > I also realized that we have a similar with the 'master' case
> > 
> > more sysfs-bus-soundwire-master
> > What:		/sys/bus/soundwire/devices/sdw-master-N/revision
> > 		/sys/bus/soundwire/devices/sdw-master-N/clk_stop_modes
> > 		/sys/bus/soundwire/devices/sdw-master-N/clk_freq
> > 		/sys/bus/soundwire/devices/sdw-master-N/clk_gears
> > 		/sys/bus/soundwire/devices/sdw-master-N/default_col
> > 		/sys/bus/soundwire/devices/sdw-master-N/default_frame_rate
> > 		/sys/bus/soundwire/devices/sdw-master-N/default_row
> > 		/sys/bus/soundwire/devices/sdw-master-N/dynamic_shape
> > 		/sys/bus/soundwire/devices/sdw-master-N/err_threshold
> > 		/sys/bus/soundwire/devices/sdw-master-N/max_clk_freq
> > 
> > If there is an update we should modify this as well for consistency with
> > sdw-master-<N>?
> 
> It is on patch 15/30:
> 
> 	https://lkml.org/lkml/2021/9/16/198
 we should have been cced :(

Thanks to b4, I was able to grab this and apply as well

-- 
~Vinod