linux-kernel - RE: [EXT] [PATCH v2 16/16] ARM: dts: ls1021a-tsn: use generic "jedec,spi-nor" compatible for flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8PR04MB8673DB448952E9E36C323555E0AB9@AS8PR04MB8673.eurprd04.prod.outlook.com>
Date:   Fri, 1 Oct 2021 05:14:52 +0000
From:   Kuldeep Singh <kuldeep.singh@....com>
To:     Leo Li <leoyang.li@....com>, Shawn Guo <shawnguo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Oleksij Rempel <linux@...pel-privat.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Leo Li <leoyang.li@....com>
Subject: RE: [EXT] [PATCH v2 16/16] ARM: dts: ls1021a-tsn: use generic
 "jedec,spi-nor" compatible for flash

> -----Original Message-----
> From: Li Yang <leoyang.li@....com>
> Sent: Friday, October 1, 2021 5:34 AM
> To: Shawn Guo <shawnguo@...nel.org>; Rob Herring
> <robh+dt@...nel.org>; devicetree@...r.kernel.org; Oleksij Rempel
> <linux@...pel-privat.de>; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Cc: Leo Li <leoyang.li@....com>
> Subject: [EXT] [PATCH v2 16/16] ARM: dts: ls1021a-tsn: use generic
> "jedec,spi-nor" compatible for flash
> 
> Caution: EXT Email
> 
> We cannot list all the possible chips used in different board revisions, just
> use the generic "jedec,spi-nor" compatible instead.  This also fixes
> dtbs_check error:
> ['s25fl256s1', 's25fl512s', 'jedec,spi-nor'] is too long
> 
> Signed-off-by: Li Yang <leoyang.li@....com>

Reviewed-by: Kuldeep Singh <kuldeep.singh@....com>

> ---
>  arch/arm/boot/dts/ls1021a-tsn.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/ls1021a-tsn.dts b/arch/arm/boot/dts/ls1021a-
> tsn.dts
> index 8005efc5c812..ff0ffb22768b 100644
> --- a/arch/arm/boot/dts/ls1021a-tsn.dts
> +++ b/arch/arm/boot/dts/ls1021a-tsn.dts
> @@ -251,7 +251,7 @@ &qspi {
> 
>         flash@0 {
>                 /* Rev. A uses 64MB flash, Rev. B & C use 32MB flash */
> -               compatible = "jedec,spi-nor", "s25fl256s1", "s25fl512s";
> +               compatible = "jedec,spi-nor";
>                 spi-max-frequency = <20000000>;
>                 #address-cells = <1>;
>                 #size-cells = <1>;
> --
> 2.25.1