linux-kernel - Re: [PATCH v7 21/24] wfx: add debug.c/debug.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 01 Oct 2021 15:01:20 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Jerome Pouiller <Jerome.Pouiller@...abs.com>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-mmc@...r.kernel.org,
        Pali Rohár <pali@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v7 21/24] wfx: add debug.c/debug.h

Jerome Pouiller <Jerome.Pouiller@...abs.com> writes:

> From: Jérôme Pouiller <jerome.pouiller@...abs.com>
>
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com>

[...]

> +static int wfx_ps_timeout_set(void *data, u64 val)
> +{
> +	struct wfx_dev *wdev = (struct wfx_dev *)data;
> +	struct wfx_vif *wvif;
> +
> +	wdev->force_ps_timeout = val;
> +	wvif = NULL;
> +	while ((wvif = wvif_iterate(wdev, wvif)) != NULL)
> +		wfx_update_pm(wvif);
> +	return 0;
> +}
> +
> +static int wfx_ps_timeout_get(void *data, u64 *val)
> +{
> +	struct wfx_dev *wdev = (struct wfx_dev *)data;
> +
> +	*val = wdev->force_ps_timeout;
> +	return 0;
> +}
> +
> +DEFINE_DEBUGFS_ATTRIBUTE(wfx_ps_timeout_fops, wfx_ps_timeout_get,
> wfx_ps_timeout_set, "%lld\n");
> +
> +int wfx_debug_init(struct wfx_dev *wdev)
> +{
> +	struct dentry *d;
> +
> +	d = debugfs_create_dir("wfx", wdev->hw->wiphy->debugfsdir);
> +	debugfs_create_file("counters", 0444, d, wdev, &wfx_counters_fops);
> +	debugfs_create_file("rx_stats", 0444, d, wdev, &wfx_rx_stats_fops);
> +	debugfs_create_file("tx_power_loop", 0444, d, wdev,
> +			    &wfx_tx_power_loop_fops);
> +	debugfs_create_file("send_pds", 0200, d, wdev, &wfx_send_pds_fops);
> +	debugfs_create_file("send_hif_msg", 0600, d, wdev,
> +			    &wfx_send_hif_msg_fops);
> +	debugfs_create_file("ps_timeout", 0600, d, wdev, &wfx_ps_timeout_fops);

ps_timeout sounds like something which should be in nl80211, not in
debugfs. Please remove it until the driver is accepted.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches