linux-kernel - Re: [PATCH] fs/9p: fix warnings found by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <061762c85ea54ff7ebaaa1b2468f1c8c5cc84eb9.camel@perches.com>
Date:   Fri, 01 Oct 2021 05:59:50 -0700
From:   Joe Perches <joe@...ches.com>
To:     Sohaib Mohamed <sohaib.amhmd@...il.com>
Cc:     Eric Van Hensbergen <ericvh@...il.com>,
        Latchesar Ionkov <lucho@...kov.net>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        v9fs-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/9p: fix warnings found by checkpatch.pl

On Fri, 2021-10-01 at 08:34 +0200, Sohaib Mohamed wrote:
> Signed-off-by: Sohaib Mohamed <sohaib.amhmd@...il.com>

try using checkpatch on your proposed patch.

> diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h
[]
> @@ -135,8 +135,8 @@ static inline struct fscache_cookie *v9fs_inode_cookie(struct v9fs_inode *v9inod
>  
> 
>  extern int v9fs_show_options(struct seq_file *m, struct dentry *root);
>  
> 
> -struct p9_fid *v9fs_session_init(struct v9fs_session_info *, const char *,
> -									char *);
> +struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, const char
> +		*dev_name, char *data);

That's really not pretty as it separates the type of the 2nd argument.

Perhaps:

struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses,
				 const char *dev_name, char *data);