linux-kernel - Re: [PATCH v3 2/4] uuid: Make guid_t completely internal type to the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVcKAH6C/dAZqoAw@smile.fi.intel.com>
Date:   Fri, 1 Oct 2021 16:15:44 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Tomas Winkler <tomas.winkler@...el.com>,
        Alexander Usyskin <alexander.usyskin@...el.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Christoph Hellwig <hch@....de>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v3 2/4] uuid: Make guid_t completely internal type to the
 kernel

On Fri, Oct 01, 2021 at 02:01:15PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 01, 2021 at 02:37:45PM +0300, Andy Shevchenko wrote:
> > The guid_t type was defined in UAPI by mistake.
> > Keep it an internal type and leave uuid_le UAPI
> > for it's only user, i.e. MEI.
> 
> It's used in they hyper-v drivers as a uapi between the kernel and the
> hypervisor, so isn't that something valid here?

I'm not sure I see that interface defined in the kernel. As far as I remember
the guid_t is used solely inside kernel by Hyper-V code and the rest is using
raw buffers. Can you point out to the specific place(s)?

> As I didn't see a 0/4 for this series, I'm confused as to your end-goal
> here.  What are you trying to do with this series?

End goal is to decouple internal type, which is guid_t, from ABI, where should
be something else in use, like __u8[16] or so.

We have two internal types, i.e. uuid_t and guid_t that are differs by byte
ordering (when represented as human-readable string). uuid_t is provided by
libuuid in the user space and its definition may be quite different to what we
have inside kernel. Kernel already hide that one. guid_t is a leftover.

I will create a cover letter for next version.

-- 
With Best Regards,
Andy Shevchenko