linux-kernel - Re: [PATCH v2 02/16] dt-bindings: i2c: imx: update schema to align with original txt binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1633094217.893290.3666445.nullmailer@robh.at.kernel.org>
Date:   Fri, 01 Oct 2021 08:16:57 -0500
From:   Rob Herring <robh@...nel.org>
To:     Li Yang <leoyang.li@....com>
Cc:     devicetree@...r.kernel.org,
        Oleksij Rempel <linux@...pel-privat.de>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH v2 02/16] dt-bindings: i2c: imx: update schema to align with original txt binding

On Thu, 30 Sep 2021 19:04:03 -0500, Li Yang wrote:
> When the binding was converted from txt to yaml, it actually added more
> constrains than the original txt binding which was already used in many
> in-tree DTSes.  Some of the newly added constrains are either not valid
> or not neccessary.
> 
> Not all SoCs use ipg as the clock name for i2c.  There is no point in
> having SoC integration information defined in i2c binding.  Remove the
> clock name requirement in the schema.
> 
> The original txt binding didn't require the order of tx and rx for
> dmas/dma-names.  Many in tree DTSes are already using the other order.
> Both orders should just work fine.  Update the schema to allow both.
> 
> Signed-off-by: Li Yang <leoyang.li@....com>
> ---
> v2:
> Updated the patch description
> 
>  Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1535099


i2c@...4000: clock-frequency:0:0: 50000 is not one of [100000, 400000]
	arch/arm/boot/dts/imx6dl-alti6p.dt.yaml

i2c@...8000: clock-frequency:0:0: 50000 is not one of [100000, 400000]
	arch/arm/boot/dts/imx6dl-alti6p.dt.yaml

i2c@...20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml

i2c@...30000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml

i2c@...40000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml

i2c@...50000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml
	arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml