linux-kernel - Re: [PATCH] x86/sev: Return an error on a returned non-zero SW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00d48af4-1683-350c-c334-08968d455e4c@amd.com>
Date:   Fri, 1 Oct 2021 08:45:17 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, Joerg Roedel <jroedel@...e.de>,
        Brijesh Singh <brijesh.singh@....com>, stable@...r.kernel.org
Subject: Re: [PATCH] x86/sev: Return an error on a returned non-zero
 SW_EXITINFO1[31:0]

On 10/1/21 4:43 AM, Borislav Petkov wrote:
> On Thu, Sep 30, 2021 at 11:42:01PM -0500, Tom Lendacky wrote:
>> After returning from a VMGEXIT NAE event, SW_EXITINFO1[31:0] is checked
>> for a value of 1, which indicates an error and that SW_EXITINFO2 contains
>> exception information. However, future versions of the GHCB specification
>> may define new values for SW_EXITINFO1[31:0], so really any non-zero value
>> should be treated as an error.
>>
> 
> So I wanna do this ontop. Might wanna apply it and look at the result -
> it shows better what the changes are.

Yup, looks good to me.

> 
> ---
> From: Borislav Petkov <bp@...e.de>
> Date: Fri, 1 Oct 2021 11:41:05 +0200
> Subject: [PATCH] x86/sev: Carve out HV call return value verification
> 
> Carve out the verification of the HV call return value into a separate
> helper and make it more readable.
> 
> No it more readable.

I'm assuming you don't want this last sentence...

Thanks,
Tom

>