linux-kernel - Re: [PATCH v2 3/4] soc: qcom: smem: Support reserved-memory description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVcZ5FsM2u+3uoK4@ripper>
Date:   Fri, 1 Oct 2021 07:23:32 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
Cc:     Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chris Lew <clew@...eaurora.org>,
        Deepak Kumar Singh <deesin@...eaurora.org>
Subject: Re: [PATCH v2 3/4] soc: qcom: smem: Support reserved-memory
 description

On Fri 01 Oct 00:08 PDT 2021, Vladimir Zapolskiy wrote:
> On 9/30/21 9:21 PM, Bjorn Andersson wrote:
[..]
> > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
[..]
> > @@ -895,12 +892,14 @@ static int qcom_smem_map_memory(struct qcom_smem *smem, struct device *dev,
> >   static int qcom_smem_probe(struct platform_device *pdev)
> >   {
> >   	struct smem_header *header;
> > +	struct reserved_mem *rmem;
> >   	struct qcom_smem *smem;
> >   	size_t array_size;
> >   	int num_regions;
> >   	int hwlock_id;
> >   	u32 version;
> >   	int ret;
> > +	int i;
> 
> Just a nitpicking, the index can be unsigned.
> 

It's compared against the "num_regions", which is also signed. So I
think it should be signed.

[..]
> > +	for (i = 0; i < num_regions; i++) {

Thanks for the review!

Regards,
Bjorn