linux-kernel - Re: [RFC PATCH net-next] drivers: net: dsa: qca8k: convert to GENMASK/FIELD_PREP/FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91eb5d7e-b62c-45e6-16a3-1d9c1c780c7b@gmail.com>
Date:   Thu, 30 Sep 2021 19:14:13 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Ansuel Smith <ansuelsmth@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net-next] drivers: net: dsa: qca8k: convert to
 GENMASK/FIELD_PREP/FIELD_GET



On 9/30/2021 6:37 PM, Ansuel Smith wrote:
> Convert and try to standardize bit fields using
> GENMASK/FIELD_PREP/FIELD_GET macros. Rework some logic to support the
> standard macro and tidy things up. No functional change intended.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> ---
> 
> I still need to test this in every part but I would like to have some
> approval about this kind of change. Also there are tons of warning by
> checkpatch about too long line... Are they accepted for headers? I can't
> really find another way to workaround the problem as reducing the define
> name would make them less descriptive.
> Aside from that I did the conversion as carefully as possible so in
> theory nothing should be broken and the conversion should be all
> correct. Some real improvement by using filed macro are in the
> fdb_read/fdb_write that now are much more readable.

My main concern is that it is going to be a tad harder to back port 
fixes made to this driver with such changes in place, so unfortunately 
it is usually a matter of either the initial version of the driver use 
BIT(), FIELD_{PREP,GET} and GENMASK, or the very few commits following 
the initial commit take care of that, and then it is all rosy for 
everyone, or else it may be complicated.

You are one of the active contributors to this driver, so ultimately you 
should decide.
-- 
Florian