linux-kernel - Re: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADRPPNTKsO7MYoUUXLgC+XnPPsrzjeBggvRnKvaB=3HUJy9-1A@mail.gmail.com>
Date:   Fri, 1 Oct 2021 15:08:05 -0500
From:   Li Yang <leoyang.li@....com>
To:     Kuldeep Singh <kuldeep.singh@....com>
Cc:     Shawn Guo <shawnguo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Oleksij Rempel <linux@...pel-privat.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI flash

On Fri, Oct 1, 2021 at 12:30 AM Kuldeep Singh <kuldeep.singh@....com> wrote:
>
> Hi Leo,
>
> > -----Original Message-----
> > From: Li Yang <leoyang.li@....com>
> > Sent: Friday, October 1, 2021 5:34 AM
> > To: Shawn Guo <shawnguo@...nel.org>; Rob Herring
> > <robh+dt@...nel.org>; devicetree@...r.kernel.org; Oleksij Rempel
> > <linux@...pel-privat.de>; linux-arm-kernel@...ts.infradead.org; linux-
> > kernel@...r.kernel.org
> > Cc: Leo Li <leoyang.li@....com>
> > Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI
> > flash
> >
> > Caution: EXT Email
> >
> > Add the missing node for qspi flash.
> >
> > Signed-off-by: Li Yang <leoyang.li@....com>
> > ---
> >  arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts
> > b/arch/arm/boot/dts/ls1021a-qds.dts
> > index e2aa569ff404..522e1dc51059 100644
> > --- a/arch/arm/boot/dts/ls1021a-qds.dts
> > +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> > @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 {
> >         };
> >  };
> >
> > +&qspi {
> > +       num-cs = <2>;
>
> Please drop "num-cs" property as it is not used by qspi driver.
>
> > +       status = "okay";
> > +
> > +       qflash0: flash@0 {
>
> Can we have flash chip name instead of qflash?
> There is no hard requirement, it will help in aligning node properties with other board properties such as LX2160A-RDB, LS1046A-RDB etc.

Thanks for the review.  I find that there is no reference to the label
at all.  I don't know why we added it in the first place.  Probably we
can just remove it?

>
> With above fixed,
> Reviewed-by: Kuldeep Singh <kuldeep.singh@....com>
>
> > +               compatible = "jedec,spi-nor";
> > +               #address-cells = <1>;
> > +               #size-cells = <1>;
> > +               spi-max-frequency = <20000000>;
> > +               reg = <0>;
> > +               spi-rx-bus-width = <4>;
> > +               spi-tx-bus-width = <4>;
> > +       };
> > +};
> > +
> >  &sai2 {
> >         status = "okay";
> >  };
> > --
> > 2.25.1
>