lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 1 Oct 2021 21:12:45 +0000
From:   <Dan.Sneddon@...rochip.com>
To:     <villeb@...esnap.co.uk>, <Tudor.Ambarus@...rochip.com>,
        <broonie@...nel.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Ludovic.Desroches@...rochip.com>
CC:     <linux-spi@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] spi: atmel: Fix PDC transfer setup bug

Hi Ville,

On 9/21/21 12:21 AM, Ville Baillie wrote:
> Commit 5fa5e6dec762 ("spi: atmel: Switch to transfer_one transfer
> method") refactored the code and changed a conditional causing
> atmel_spi_dma_map_xfer to never be called in PDC mode. This causes the
> driver to silently fail.
> 
> This patch changes the conditional to match the behaviour of the
> previous commit before the refactor.
> 
> Signed-off-by: Ville Baillie <villeb@...esnap.co.uk>
Shouldn't this have a FIXES tag?
> ---
>   drivers/spi/spi-atmel.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 788dcdf25f00..f872cf196c2f 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1301,7 +1301,7 @@ static int atmel_spi_one_transfer(struct spi_master *master,
>   	 * DMA map early, for performance (empties dcache ASAP) and
>   	 * better fault reporting.
>   	 */
> -	if ((!master->cur_msg_mapped)
> +	if ((!master->cur_msg->is_dma_mapped)
>   		&& as->use_pdc) {
>   		if (atmel_spi_dma_map_xfer(as, xfer) < 0)
>   			return -ENOMEM;
> @@ -1381,7 +1381,7 @@ static int atmel_spi_one_transfer(struct spi_master *master,
>   		}
>   	}
>   
> -	if (!master->cur_msg_mapped
> +	if (!master->cur_msg->is_dma_mapped
>   		&& as->use_pdc)
>   		atmel_spi_dma_unmap_xfer(master, xfer);
>   
> 

Regards,
Dan

Powered by blists - more mailing lists