linux-kernel - Re: [PATCH] openrisc: time: don't mark comment as kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 2 Oct 2021 21:38:16 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        openrisc@...ts.librecores.org
Subject: Re: [PATCH] openrisc: time: don't mark comment as kernel-doc

On Thu, Sep 30, 2021 at 07:11:01PM -0700, Randy Dunlap wrote:
> Fix a kernel-doc warning by unmarking the comment as being in
> kernel-doc notation.
> 
> Fixes this warning:
> arch/openrisc/kernel/time.c:137: warning: expecting prototype for Clocksource(). Prototype was for openrisc_timer_read() instead
> 
> Fixes: b731fbbd246e ("OpenRISC: Timekeeping")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Jonas Bonn <jonas@...thpole.se>
> Cc: Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>
> Cc: Stafford Horne <shorne@...il.com>
> Cc: openrisc@...ts.librecores.org
> ---
>  arch/openrisc/kernel/time.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20210930.orig/arch/openrisc/kernel/time.c
> +++ linux-next-20210930/arch/openrisc/kernel/time.c
> @@ -127,7 +127,7 @@ irqreturn_t __irq_entry timer_interrupt(
>  	return IRQ_HANDLED;
>  }
>  
> -/**
> +/*
>   * Clocksource: Based on OpenRISC timer/counter
>   *
>   * This sets up the OpenRISC Tick Timer as a clock source.  The tick timer

Hi Randy,

This looks good to me, thank you.  I am queuing it.

-Stafford