linux-kernel - Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211002170901.7378fcc4@jic23-huawei>
Date:   Sat, 2 Oct 2021 17:09:01 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     Cai Huoqing <caihuoqing@...du.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        linux-arm-kernel@...ts.infradead.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper
 function dev_err_probe()

On Sat, 2 Oct 2021 15:01:56 +0200
Martin Blumenstingl <martin.blumenstingl@...glemail.com> wrote:

> On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@...du.com> wrote:
> >
> > When possible use dev_err_probe help to properly deal with the
> > PROBE_DEFER error, the benefit is that DEFER issue will be logged
> > in the devices_deferred debugfs file.
> > Using dev_err_probe() can reduce code size, and the error value
> > gets printed.
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@...du.com>  
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> as well as:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> # Odroid-C1
Hi Martin,

Confusing tag.  Was the second meant to be a Tested-by?

Thanks,

Jonathan
> 
> Thanks for your contribution!
> 
> 
> Best regards,
> Martin