linux-kernel - Re: [PATCH] staging: r8188eu: core: remove unused variable pAdapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c00d96ef-0168-c004-7fb1-a422a7c8aaa3@gmail.com>
Date:   Sat, 2 Oct 2021 21:39:20 +0530
From:   Saurav Girepunje <saurav.girepunje@...il.com>
To:     Michael Straube <straube.linux@...il.com>,
        Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Cc:     saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove unused variable pAdapter



On 02/10/21 9:08 pm, Michael Straube wrote:
> Thanks for you patch Saurav, just some minor style issue.
> 
> On 10/2/21 17:13, Saurav Girepunje wrote:
>> Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
>> ---
>>   drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++----
>>   1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c 
>> b/drivers/staging/r8188eu/core/rtw_efuse.c
>> index 801887f497cf..d33a5b3b4088 100644
>> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
>> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
>> @@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
>>   #define REG_EFUSE_CTRL        0x0030
>>   #define EFUSE_CTRL            REG_EFUSE_CTRL        /*  E-Fuse 
>> Control. */
>>
>> -static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
>> -                       u16 Offset,
>> +static bool Efuse_Read1ByteFromFakeContent(u16 Offset,
>>                          u8 *Value)
> 
> There is no need for a line break here.                 ^
> 
> Other than that looks good to me.
> 
> Thanks,
> Michael

Thanks Michael for review. Yes line break not needed here. I will 
update. I will resend the patch.

Regards,
Saurav