lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Sun,  3 Oct 2021 06:17:23 +0700
From:   Ammar Faizi <ammar.faizi@...dents.amikom.ac.id>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Ammar Faizi <ammar.faizi@...dents.amikom.ac.id>,
        Pavel Skripkin <paskripkin@...il.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        Bedirhan KURT <windowz414@...weeb.org>
Subject: [PATCH] media: atomisp: fix `-Werror=return-type`

Bedirhan reported build error:
```
  drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
  drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
   1649 | }
        | ^
  cc1: some warnings being treated as errors
  make[4]: *** [scripts/Makefile.build:277: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o] Error 1
  make[3]: *** [scripts/Makefile.build:540: drivers/staging/media/atomisp] Error 2
  make[2]: *** [scripts/Makefile.build:540: drivers/staging/media] Error 2
  make[1]: *** [scripts/Makefile.build:540: drivers/staging] Error 2
  make: *** [Makefile:1868: drivers] Error 2
```

Commit 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp:
remove useless returns") incorrectly removed a required return results
in the above build error. Reinstate it.

Cc: Pavel Skripkin <paskripkin@...il.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: linux-media@...r.kernel.org
Cc: linux-staging@...ts.linux.dev
Cc: linux-kernel@...r.kernel.org
Reported-by: Bedirhan KURT <windowz414@...weeb.org>
Fixes: 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp: remove useless returns")
Signed-off-by: Ammar Faizi <ammar.faizi@...dents.amikom.ac.id>
---
 .../media/atomisp/pci/hive_isp_css_common/host/input_system.c    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
index 8e085dda0c18..1bd917e81743 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
@@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
 	default:
 		return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
 	}
+	return INPUT_SYSTEM_ERR_NO_ERROR;
 }
 
 // Test flags and set structure.
-- 
2.30.2

Powered by blists - more mailing lists