linux-kernel - Re: [PATCH v7 2/7] i2c: mediatek: Reset the handshake signal between i2c and dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 2 Oct 2021 08:30:37 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Kewei Xu <kewei.xu@...iatek.com>
Cc:     matthias.bgg@...il.com, robh+dt@...nel.org,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, srv_heupstream@...iatek.com,
        leilk.liu@...iatek.com, qii.wang@...iatek.com,
        liguo.zhang@...iatek.com, caiyu.chen@...iatek.com,
        ot_daolong.zhu@...iatek.com, yuhan.wei@...iatek.com
Subject: Re: [PATCH v7 2/7] i2c: mediatek: Reset the handshake signal between
 i2c and dma


> +#define I2C_CLR_DEBUGCTR		0x0000

Hmm, I don't think that a macro to clear a register helps readability...

> +		mtk_i2c_writew(i2c, I2C_CLR_DEBUGCTR, OFFSET_DEBUGCTRL);

...

 +		mtk_i2c_writew(i2c, 0, OFFSET_DEBUGCTRL);

looks good to me. Anyhow, it is not a big issue. Let me know if you want
to change it or keep it.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)