linux-kernel - Re: [PATCH] powerpc/fsl/dts: Fix phy-connection-type for fm1mac3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 2 Oct 2021 11:06:30 +0200
From:   Pali Rohár <pali@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Russell King <linux@...linux.org.uk>,
        Madalin Bucur <madalin.bucur@....com>,
        "Camelia Alexandra Groza (OSS)" <camelia.groza@....nxp.com>,
        Rob Herring <robh+dt@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Marek Behún <kabel@...nel.org>,
        Scott Wood <oss@...error.net>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/fsl/dts: Fix phy-connection-type for fm1mac3

On Wednesday 29 September 2021 16:25:01 Andrew Lunn wrote:
> On Tue, Sep 28, 2021 at 11:39:18PM +0200, Pali Rohár wrote:
> > On Friday 27 August 2021 13:38:36 Pali Rohár wrote:
> > > On Wednesday 14 July 2021 12:11:49 Scott Wood wrote:
> > > > On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote:
> > > > > Property phy-connection-type contains invalid value "sgmii-2500" per scheme
> > > > > defined in file ethernet-controller.yaml.
> > > > > 
> > > > > Correct phy-connection-type value should be "2500base-x".
> > > > > 
> > > > > Signed-off-by: Pali Rohár <pali@...nel.org>
> > > > > Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the
> > > > > board device tree(s)")
> > > > > ---
> > > > >  arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > > > > b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > > > > index 5ba6fbfca274..f82f85c65964 100644
> > > > > --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > > > > +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > > > > @@ -154,7 +154,7 @@
> > > > >  
> > > > >                         fm1mac3: ethernet@...00 {
> > > > >                                 phy-handle = <&sgmii_aqr_phy3>;
> > > > > -                               phy-connection-type = "sgmii-2500";
> > > > > +                               phy-connection-type = "2500base-x";
> > > > >                                 sleep = <&rcpm 0x20000000>;
> > > > >                         };
> > > > >  
> > > > 
> > > > Acked-by: Scott Wood <oss@...error.net>
> > > > 
> > > > -Scott
> > > 
> > > Hello! If there is not any objection, could you take this patch?
> > 
> > Hello! I would like to remind this patch.
> 
> Hi Pali
> 
> I suggest you resend, and with To: Michael Ellerman <mpe@...erman.id.au>
> to make it clear who you expect to pick up the
> patch. Michael seems to do the Maintainer work in
> arch/powerpc/boot/dts/
> 
> 	Andrew

Done: https://lore.kernel.org/lkml/20211002090409.3833-1-pali@kernel.org/T/#u