lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Oct 2021 21:33:54 +0300 From: Kari Argillander <kari.argillander@...il.com> To: Konstantin Komarov <almaz.alexandrovich@...agon-software.com> Cc: ntfs3@...ts.linux.dev, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH] fs/ntfs3: Keep prealloc for all types of files On Fri, Oct 01, 2021 at 06:58:03PM +0300, Konstantin Komarov wrote: > Fixes: xfstest generic/274 I would always hope at least couple sentence to commit message. It would be easier if you do this in first place and I do not need to ask it everytime. Again I'm straight away thinking why this was done this way in a first place. There has to be reason. Was that reason totally wrong in a first place? Does this patch has some drawbacks? Quick look it looks it might have, but please write about it so reviewer job is little easier and we get more meaningfull history. This also again needs fixes tag with prober commit id as this seems like a bug if this fix xfstests case. > Signed-off-by: Konstantin Komarov <almaz.alexandrovich@...agon-software.com> > --- > fs/ntfs3/attrib.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c > index 8a00fa978f5f..e8c00dda42ad 100644 > --- a/fs/ntfs3/attrib.c > +++ b/fs/ntfs3/attrib.c > @@ -447,11 +447,8 @@ int attr_set_size(struct ntfs_inode *ni, enum ATTR_TYPE type, > again_1: > align = sbi->cluster_size; > > - if (is_ext) { > + if (is_ext) > align <<= attr_b->nres.c_unit; > - if (is_attr_sparsed(attr_b)) > - keep_prealloc = false; > - } > > old_valid = le64_to_cpu(attr_b->nres.valid_size); > old_size = le64_to_cpu(attr_b->nres.data_size); > @@ -461,9 +458,6 @@ int attr_set_size(struct ntfs_inode *ni, enum ATTR_TYPE type, > new_alloc = (new_size + align - 1) & ~(u64)(align - 1); > new_alen = new_alloc >> cluster_bits; > > - if (keep_prealloc && is_ext) > - keep_prealloc = false; > - > if (keep_prealloc && new_size < old_size) { > attr_b->nres.data_size = cpu_to_le64(new_size); > mi_b->dirty = true; > -- > 2.33.0 >
Powered by blists - more mailing lists