linux-kernel - Re: [PATCH 0/3] Update ASUS WMI supported boards.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfgGZ1+YfsvfSaUP7+JgKok7oAJJzTni_cPUj0eHXNaBw@mail.gmail.com>
Date:   Sun, 3 Oct 2021 09:39:44 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Denis Pauk <pauk.denis@...il.com>
Cc:     Eugene Shalygin <eugene.shalygin@...il.com>,
        matt-testalltheway <sefoci9222@...unway.com>,
        Kamil Dudka <kdudka@...hat.com>,
        Robert Swiecki <robert@...ecki.net>,
        Kamil Pietrzak <kpietrzak@...root.org>, Igor <igor@...lig.com>,
        Tor Vic <torvic9@...lbox.org>, Poezevara <nephartyz@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-hwmon@...r.kernel.org
Subject: Re: [PATCH 0/3] Update ASUS WMI supported boards.

On Sun, Oct 3, 2021 at 12:10 AM Denis Pauk <pauk.denis@...il.com> wrote:
>
> Add support to nct6775:
> * PRIME B360-PLUS
> * PRIME X570-PRO
> * ROG CROSSHAIR VIII FORMULA
> * ROG STRIX B550-I GAMING
> * ROG STRIX X570-F GAMING
> * ROG STRIX Z390-E GAMING
> * TUF GAMING B550-PRO
> * TUF GAMING Z490-PLUS
> * TUF GAMING Z490-PLUS (WI-FI)
>
> Add sensors driver for ASUS motherboards to read sensors from the embedded
> controller. Based on https://github.com/zeule/asus-wmi-ec-sensors.
>
> Could you please review?

I will look at the last patch later on.

> @Andy Shevchenko, @Guenter Roeck should I split last patch in some way?
> Should I add to MAINTAINERS:
> --
> ASUS WMI HARDWARE MONITOR DRIVER
> M:     Eugene Shalygin <eugene.shalygin@...il.com>
> M:     Denis Pauk <pauk.denis@...il.com>
> L:     linux-hwmon@...r.kernel.org
> S:     Maintained
> F:     drivers/hwmon/asus_wmi_sensors.c

I don't see right now if the last patch needs a split, but MAINTAINERS
update is better to have.

...

> Signed-off-by: Denis Pauk <pauk.denis@...il.com>

This makes a little sense in a cover letter (have you used
--cover-letter parameter?).

> Co-developed-by: Eugene Shalygin <eugene.shalygin@...il.com>
> Signed-off-by: Eugene Shalygin <eugene.shalygin@...il.com>

This in a similar way, except the outcome is an appearing above
mentioned name in the Cc.

> Tested-by: matt-testalltheway <sefoci9222@...unway.com>
> Tested-by: Kamil Dudka <kdudka@...hat.com>
> Tested-by: Robert Swiecki <robert@...ecki.net>
> Tested-by: Kamil Pietrzak <kpietrzak@...root.org>
> Tested-by: Igor <igor@...lig.com>
> Tested-by: Tor Vic <torvic9@...lbox.org>
> Tested-by: Poezevara <nephartyz@...il.com>

This is fine (and will be reflected in Cc)

> Cc: Andy Shevchenko <andriy.shevchenko@...el.com>
> Cc: Guenter Roeck <linux@...ck-us.net>

This I already talked about.

-- 
With Best Regards,
Andy Shevchenko