linux-kernel - Re: [PATCH] r8152: stop submitting rx for -EPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211004143305.GA583555@rowland.harvard.edu>
Date:   Mon, 4 Oct 2021 10:33:05 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     Hayes Wang <hayeswang@...ltek.com>,
        Jason-ch Chen <jason-ch.chen@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "Project_Global_Chrome_Upstream_Group@...iatek.com" 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...gle.com" <hsinyi@...gle.com>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: Re: [PATCH] r8152: stop submitting rx for -EPROTO

On Mon, Oct 04, 2021 at 01:44:54PM +0200, Oliver Neukum wrote:
> 
> On 01.10.21 17:22, Alan Stern wrote:
> > On Fri, Oct 01, 2021 at 03:26:48AM +0000, Hayes Wang wrote:
> >>> Alan Stern <stern@...land.harvard.edu>
> >>> [...]
> >>>> There has been some discussion about this in the past.
> >>>>
> >>>> In general, -EPROTO is almost always a non-recoverable error.
> >>> Excuse me. I am confused about the above description.
> >>> I got -EPROTO before, when I debugged another issue.
> >>> However, the bulk transfer still worked after I resubmitted
> >>> the transfer. I didn't do anything to recover it. That is why
> >>> I do resubmission for -EPROTO.
> >> I check the Linux driver and the xHCI spec.
> >> The driver gets -EPROTO for bulk transfer, when the host
> >> returns COMP_USB_TRANSACTION_ERROR.
> >> According to the spec of xHCI, USB TRANSACTION ERROR
> >> means the host did not receive a valid response from the
> >> device (Timeout, CRC, Bad PID, unexpected NYET, etc.).
> > That's right.  If the device and cable are working properly, this 
> > should never happen.  Or only extremely rarely (for example, caused 
> > by external electromagnetic interference).
> And the device. I am afraid the condition in your conditional statement
> is not as likely to be true as would be desirable for quite a lot setups.

But if the device isn't working, a simple retry is most unlikely to fix 
the problem.  Some form of active error recovery, such as a bus reset, 
will be necessary.  For a non-working cable, even a reset won't help -- 
the user would have to physically adjust or replace the cable.

> >> It seems to be reasonable why resubmission sometimes works.
> > Did you ever track down the reason why you got the -EPROTO error 
> > while debugging that other issue?  Can you reproduce it?
> 
> Is that really the issue though? We are seeing this issue with EPROTO.
> But wouldn't we see it with any recoverable error?

If you mean an error that can be fixed but only by doing something more 
than a simple retry, then yes.  However, the vast majority of USB 
drivers do not attempt anything more than a simple retry.  Relatively 
few of them (including usbhid and mass-storage) are more sophisticated 
in their error handling.

> AFAICT we are running into a situation without progress because drivers
> retry
> 
> * forever
> * immediately
> 
> If we broke any of these conditions the system would proceed and the
> hotplug event be eventually be processed. We may ask whether drivers should
> retry forever, but I don't see that you can blame it on error codes.

It's important to distinguish between:

    1.	errors that are transient and will disappear very quickly,
	meaning that a retry has a good chance of working, and

    2.	errors that are effectively permanent (or at least, long-lived)
	and therefore are highly unlikely to be fixed by retrying.

My point is that there is no reason to retry in case 2, and -EPROTO 
falls into this case (as do -EILSEQ and -ETIME).

Converting drivers to keep track of their retries, to avoid retrying 
forever, would be a fairly large change.  Even implementing delayed 
retries requires some significant work (as you can see in Hayes's recent 
patch -- and that was an easy case because the NAPI infrastructure was 
already present).  It's much simpler to avoid retrying entirely in 
situations where retries won't help.

And it's even simpler if the USB core would automatically prevent 
retries (by failing URB submissions after low-level protocol errors) in 
these situations.

Alan Stern