linux-kernel - Re: [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Oct 2021 16:59:31 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells
 dependency

On 04/10/2021 16:56, Rob Herring wrote:
> On Tue, Sep 28, 2021 at 10:23:46AM +0200, Krzysztof Kozlowski wrote:
>> The meta-schema already defines dependency between clock-cells and
> 
> You mean the schema already does.

Yes.

> 
>> clock-output-names.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>> ---
>>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> index 23abb7e8b9d8..dd70431df0b7 100644
>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> @@ -158,10 +158,6 @@ properties:
>>      description:
>>        The MIO bank number in which the command and data lines are configured.
>>  
>> -dependencies:
>> -  clock-output-names: [ '#clock-cells' ]
> 
> The schema defines this.
> 
>> -  '#clock-cells': [ clock-output-names ]
> 
> But not this. That's because in the common case, clock-output-names is 
> optional. But here it is required when '#clock-cells' is present.

You are right, somehow I missed that part...


Best regards,
Krzysztof