linux-kernel - Re: [PATCH] drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ec7d7c5-301f-ad34-fd40-844e81e1cdb9@gmail.com>
Date:   Tue, 5 Oct 2021 00:09:28 +0900
From:   Akira Yokosawa <akiyks@...il.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Jonathan Corbet <corbet@....net>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915/guc, docs: Fix pdfdocs build error by removing
 nested grid

On Thu, 23 Sep 2021 18:10:23 +0300, Jani Nikula wrote:
> On Mon, 20 Sep 2021, Akira Yokosawa <akiyks@...il.com> wrote:
>> Nested grids in grid-table cells are not specified as proper ReST
>> constructs.
>> Commit 572f2a5cd974 ("drm/i915/guc: Update firmware to v62.0.0")
>> added a couple of kerneldoc tables of the form:
>>
>>   +---+-------+------------------------------------------------------+
>>   | 1 |  31:0 |  +------------------------------------------------+  |
>>   +---+-------+  |                                                |  |
>>   |...|       |  |  Embedded `HXG Message`_                       |  |
>>   +---+-------+  |                                                |  |
>>   | n |  31:0 |  +------------------------------------------------+  |
>>   +---+-------+------------------------------------------------------+
>>
>> For "make htmldocs", they happen to work as one might expect,
>> but they are incompatible with "make latexdocs" and "make pdfdocs",
>> and cause the generated gpu.tex file to become incomplete and
>> unbuildable by xelatex.
>>
>> Restore the compatibility by removing those nested grids in the tables.
>>
>> Size comparison of generated gpu.tex:
>>
>>                   Sphinx 2.4.4  Sphinx 4.2.0
>>   v5.14:               3238686       3841631
>>   v5.15-rc1:            376270        432729
>>   with this fix:       3377846       3998095
>>
>> Fixes: 572f2a5cd974 ("drm/i915/guc: Update firmware to v62.0.0")
>> Cc: John Harrison <John.C.Harrison@...el.com>
>> Cc: Michal Wajdeczko <michal.wajdeczko@...el.com>
>> Cc: Matthew Brost <matthew.brost@...el.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@...el.com>
>> Cc: Matt Roper <matthew.d.roper@...el.com>
>> Cc: Jonathan Corbet <corbet@....net>
>> Signed-off-by: Akira Yokosawa <akiyks@...il.com>
> 
> Pushed to drm-intel-gt-next, thanks for the patch.
> 
> This makes the HTML output arguably worse, but there were no comments
> from anyone and the pdf build needs to work.

[Dropped most CCs]

Hi Jani,

Thank you for taking care of this patch.

Jon, as this has reached upstream, can you back-merge v5.15-rc4
into docs-next so that "make pdfdocs" can complete?

I tried the back-merge without seeing any conflict.
"make pdfdocs" finishes successfully now.

        Thanks, Akira

> 
> BR,
> Jani.
> 
> 
> 
>> ---
[...]