linux-kernel - Re: [RESEND PATCH] sched/topology: Remove unused numa_distance in cpu_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y278lsu0.mognet@arm.com>
Date:   Mon, 04 Oct 2021 16:20:39 +0100
From:   Valentin Schneider <valentin.schneider@....com>
To:     Yicong Yang <yangyicong@...ilicon.com>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, 21cnbao@...il.com
Cc:     linux-kernel@...r.kernel.org, song.bao.hua@...ilicon.com,
        prime.zeng@...wei.com, yangyicong@...ilicon.com
Subject: Re: [RESEND PATCH] sched/topology: Remove unused numa_distance in cpu_attach_domain()

On 15/09/21 14:31, Yicong Yang wrote:
> numa_distance in cpu_attach_domain() is introduced in
> commit b5b217346de8 ("sched/topology: Warn when NUMA diameter > 2")
> to warn user when NUMA diameter > 2 as we'll misrepresent
> the scheduler topology structures at that time. This is
> fixed by Barry in commit 585b6d2723dc ("sched/topology: fix the issue
> groups don't span domain->span for NUMA diameter > 2") and
> numa_distance is unused now. So remove it.
>

Ah, 585b6d2723dc didn't contain a proper revert of b5b217346de8, leaving
those hunks behind.

Reviewed-by: Valentin Schneider <valentin.schneider@....com>