lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 04 Oct 2021 17:30:26 +0100 From: Marc Zyngier <maz@...nel.org> To: Pingfan Liu <kernelfans@...il.com> Cc: linux-arm-kernel@...ts.infradead.org, Mark Rutland <mark.rutland@....com>, "Paul E. McKenney" <paulmck@...nel.org>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Joey Gouly <joey.gouly@....com>, Sami Tolvanen <samitolvanen@...gle.com>, Julien Thierry <julien.thierry@....com>, Thomas Gleixner <tglx@...utronix.de>, Yuichi Ito <ito-yuichi@...itsu.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCHv4 1/3] kernel/irq: make irq_{enter,exit}() in handle_domain_irq() arch optional On Fri, 01 Oct 2021 15:44:04 +0100, Pingfan Liu <kernelfans@...il.com> wrote: > > When an IRQ is taken, some accounting needs to be performed to enter and > exit IRQ context around the IRQ handler. Historically arch code would > leave this to the irqchip or core IRQ code, but these days we want this > to happen in exception entry code, and architectures such as arm64 do > this. > > Currently handle_domain_irq() performs this entry/exit accounting, and > if used on an architecture where the entry code also does this, the > entry/exit accounting will be performed twice per IRQ. This is > problematic as core RCU code such as rcu_is_cpu_rrupt_from_idle() > depends on this happening once per IRQ, and will not detect quescent > periods correctly, leading to stall warnings. > > As irqchip drivers which use handle_domain_irq() need to work on > architectures with or without their own entry/exit accounting, this > patch makes handle_domain_irq() conditionally perform the entry > accounting depending on a new HAVE_ARCH_IRQENTRY Kconfig symbol that > architectures can select if they perform this entry accounting > themselves. > > For architectures which do not select the symbol. there should be no > functional change as a result of this patch. > > Signed-off-by: Pingfan Liu <kernelfans@...il.com> > Reviewed-by: Mark Rutland <mark.rutland@....com> > Cc: "Paul E. McKenney" <paulmck@...nel.org> > Cc: Catalin Marinas <catalin.marinas@....com> > Cc: Will Deacon <will@...nel.org> > Cc: Marc Zyngier <maz@...nel.org> > Cc: Joey Gouly <joey.gouly@....com> > Cc: Sami Tolvanen <samitolvanen@...gle.com> > Cc: Julien Thierry <julien.thierry@....com> > Cc: Thomas Gleixner <tglx@...utronix.de> > Cc: Yuichi Ito <ito-yuichi@...itsu.com> > Cc: linux-kernel@...r.kernel.org > To: linux-arm-kernel@...ts.infradead.org Reviewed-by: Marc Zyngier <maz@...nel.org> M. -- Without deviation from the norm, progress is not possible.
Powered by blists - more mailing lists