linux-kernel - Re: [PATCH V0 1/7] dt-bindings: connector: Add property for eud type c connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Oct 2021 11:37:09 -0500
From:   Rob Herring <robh@...nel.org>
To:     Souradeep Chowdhury <schowdhu@...eaurora.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org,
        Bryan O'Donoghue <pure.logic@...us-software.ie>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org,
        ckadabi@...eaurora.org, tsoni@...eaurora.org,
        bryanh@...eaurora.org, psodagud@...eaurora.org,
        satyap@...eaurora.org, pheragu@...eaurora.org,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Sibi Sankar <sibis@...eaurora.org>,
        Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
Subject: Re: [PATCH V0 1/7] dt-bindings: connector: Add property for eud type
 c connector

On Mon, Oct 04, 2021 at 04:46:19PM +0530, Souradeep Chowdhury wrote:
> Added the property for EUD(Embedded USB Debug) connector.Added
> the "reg" and "interrupts" property which is needed for EUD.

You are going to need a better explanation of this h/w.

> 
> Signed-off-by: Souradeep Chowdhury <schowdhu@...eaurora.org>
> ---
>  .../devicetree/bindings/connector/usb-connector.yaml      | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 7eb8659..908129f 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -30,6 +30,21 @@ properties:
>            - const: samsung,usb-connector-11pin
>            - const: usb-b-connector
>  
> +      - items:
> +          - enum:
> +              - qcom,sc7280-usb-connector-eud
> +          - const: qcom,usb-connector-eud
> +          - const: usb-c-connector
> +
> +  reg:
> +    items:
> +      - description: EUD Base Register Region
> +      - description: EUD Mode Manager Region

A connector node represents the physical connector on a board. That 
can't really be an MMIO peripheral. Maybe you need a node for EUD and 
then it should have a connector child node? Don't really know without 
understanding this h/w.

> +
> +  interrupts:
> +    description:
> +      EUD interrupt
> +
>    label:
>      description: Symbolic name for the connector.
>  
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
> 
>