linux-kernel - Re: [PATCH] EDAC/mc_sysfs: Print MC-scope sysfs counters unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Oct 2021 09:53:18 -0700
From:   Eric Badger <ebadger@...estorage.com>
To:     "Luck, Tony" <tony.luck@...el.com>
Cc:     Borislav Petkov <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>,
        "open list:EDAC-CORE" <linux-edac@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] EDAC/mc_sysfs: Print MC-scope sysfs counters unsigned

On Mon, Oct 04, 2021 at 03:21:13PM +0000, Luck, Tony wrote:
> > This is cosmetically nicer for counts > INT32_MAX, and aligns the
> > MC-scope format with that of the lower layer sysfs counter files.
> 
> While this is technically the right thing to do, I pity the system administrator that
> is looking at a system with more than 2147483647 corrected or uncorrected errors!
> 
> So:
> 
> Acked-by: Tony Luck <tony.luck@...el.com>
> 
> but maybe this is just churn and not really useful in practice?

Pity accepted :). I only noticed the sign mismatch after seeing a
negative value on a server in the wild. But it's cosmetic really; if
you've reached INT32_MAX you'll probably reach UINT32_MAX and can't rely
on the counter.

Cheers,
Eric