linux-kernel - Re: [PATCH v3 4/4] memory: tegra20-emc: Support matching timings by LPDDR2 configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e41c944e-1b01-ef09-78a9-8dab7f97b054@gmail.com>
Date:   Mon, 4 Oct 2021 20:05:15 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH v3 4/4] memory: tegra20-emc: Support matching timings by
 LPDDR2 configuration

04.10.2021 12:09, Krzysztof Kozlowski пишет:
>>  static int emc_setup_hw(struct tegra_emc *emc)
>>  {
>> +	u32 emc_cfg, emc_dbg, emc_fbio, emc_adr_cfg;
>>  	u32 intmask = EMC_REFRESH_OVERFLOW_INT;
>> -	u32 emc_cfg, emc_dbg, emc_fbio;
>> +	static bool print_sdram_info_once;
> How about moving print_sdram_info_once to emc_read_lpddr_sdram_info()?
> Less code here.
> 

The SDRAM info is printed out for each attached SDRAM chip. There are
two prints if two chips are attached to memory controller. Hence this
print_once flag should cover both prints.