linux-kernel - Re: [PATCH] staging: rtl8723bs: core: remove condition never execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Oct 2021 09:59:47 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Saurav Girepunje <saurav.girepunje@...il.com>,
        gregkh@...uxfoundation.org, fabioaiuto83@...il.com,
        ross.schm.dev@...il.com, marcocesati@...il.com,
        fmdefrancesco@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Cc:     saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: rtl8723bs: core: remove condition never execute


Hi,

On 10/3/21 5:58 PM, Saurav Girepunje wrote:
> Remove condition which never get execute.
> as pattrib->mdata is always zero before if condition check.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans

> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index b2c042c36777..3ee4d35ca8d7 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -3222,9 +3222,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da,
>  	else if ((pmlmeinfo->state&0x03) == WIFI_FW_STATION_STATE)
>  		SetToDs(fctrl);
> 
> -	if (pattrib->mdata)
> -		SetMData(fctrl);
> -
>  	qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
> 
>  	SetPriority(qc, tid);
> --
> 2.32.0
>