linux-kernel - Re: [PATCH v6] kallsyms: strip LTO suffixes from static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <163337043811.3396838.458236649388694225.b4-ty@chromium.org>
Date:   Mon,  4 Oct 2021 11:00:55 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        "KE . LI" <like1@...o.com>, Stephen Boyd <swboyd@...omium.org>,
        Fangrui Song <maskray@...gle.com>,
        Miroslav Benes <mbenes@...e.cz>,
        Padmanabha Srinivasaiah <treasure4paddy@...il.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Joe Perches <joe@...ches.com>, Jessica Yu <jeyu@...nel.org>,
        Sami Tolvanen <samitolvanen@...gle.com>, llvm@...ts.linux.dev
Subject: Re: [PATCH v6] kallsyms: strip LTO suffixes from static functions

On Mon, 4 Oct 2021 09:29:33 -0700, Nick Desaulniers wrote:
> Similar to:
> commit 8b8e6b5d3b01 ("kallsyms: strip ThinLTO hashes from static
> functions")
> 
> It's very common for compilers to modify the symbol name for static
> functions as part of optimizing transformations. That makes hooking
> static functions (that weren't inlined or DCE'd) with kprobes difficult.
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] kallsyms: strip LTO suffixes from static functions
      https://git.kernel.org/kees/c/6eb4bd92c1ce

Also,if you get a moment, can you set up patatt (or b4) to sign your
outgoing patches? DKIM is nice, but I'd like to see more folks signing
their emailed patches: https://github.com/mricon/patatt

tl;dr:

add to ~/.gitconfig:
[patatt]
    signingkey = openpgp:FINGERPRINT-HERE

# install git sendemail hook (assuming you send with git)
$ patatt install-hook

# or do it manually before sending:
$ patatt sign $file-with-email

Thanks!

-- 
Kees Cook