linux-kernel - Re: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVtQNSoCJG5cJb4b@rocinante>
Date:   Mon, 4 Oct 2021 21:04:21 +0200
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Max Gurtovoy <mgurtovoy@...dia.com>
Cc:     hch@...radead.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org, linux-pci@...r.kernel.org,
        bhelgaas@...gle.com, stefanha@...hat.com, oren@...dia.com
Subject: Re: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro

Hi Max!

> Use the proper macro instead of hard-coded (-1) value.
> 
> Suggested-by: Krzysztof Wilczyński <kw@...ux.com>
> Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@...dia.com>
> ---
>  drivers/pci/pci-sysfs.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 7fb5cd17cc98..f807b92afa6c 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
>  	const struct cpumask *mask;
>  
>  #ifdef CONFIG_NUMA
> -	mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
> -					  cpumask_of_node(dev_to_node(dev));
> +	if (dev_to_node(dev) == NUMA_NO_NODE)
> +		mask = cpu_online_mask;
> +	else
> +		mask = cpumask_of_node(dev_to_node(dev));
>  #else
>  	mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
>  #endif
> -- 
> 2.18.1

Thank you!

	Krzysztof