linux-kernel - Re: [PATCH v2 2/2] PCI/sysfs: use NUMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YVtQ8ummGgG9AOZE@rocinante>
Date:   Mon, 4 Oct 2021 21:07:30 +0200
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Max Gurtovoy <mgurtovoy@...dia.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, gregkh@...uxfoundation.org,
        hch@...radead.org, stefanha@...hat.com, oren@...dia.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] PCI/sysfs: use NUMA_NO_NODE macro

Hi Max,

[...]
> >  #ifdef CONFIG_NUMA
> > -	mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
> > -					  cpumask_of_node(dev_to_node(dev));
> > +	mask = (dev_to_node(dev) == NUMA_NO_NODE) ? cpu_online_mask :
> > +				cpumask_of_node(dev_to_node(dev));
> 
> Oh this somewhat awkward indentation we have with this ternary now,
> and so I wonder if either:
> 
> 	mask = (dev_to_node(dev) == NUMA_NO_NODE) ?
> 		cpu_online_mask : cpumask_of_node(dev_to_node(dev));
> 
> Or, perhaps (yes, a few more lines):
> 
> 	if (dev_to_node(dev) == NUMA_NO_NODE)
> 		mask = cpu_online_mask;
> 	else
> 		mask = cpumask_of_node(node);

Doh!  I should be cpumask_of_node(dev_to_node(dev)) in the above, of
course.  Apologies!  Albeit, v3 you sent looks great!  Thank you!

	Krzysztof