linux-kernel - Re: [PATCH v6] kallsyms: strip LTO suffixes from static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211004194521.e2syd25qzrgn5mzg@meerkat.local>
Date:   Mon, 4 Oct 2021 15:45:21 -0400
From:   Konstantin Ryabitsev <konstantin@...uxfoundation.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] kallsyms: strip LTO suffixes from static functions

On Mon, Oct 04, 2021 at 11:41:29AM -0700, Nick Desaulniers wrote:
> On Mon, Oct 4, 2021 at 11:38 AM Konstantin Ryabitsev
> <konstantin@...uxfoundation.org> wrote:
> >
> > On Mon, Oct 04, 2021 at 11:32:43AM -0700, Nick Desaulniers wrote:
> > > $ git format-patch HEAD~
> > > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > > $ git send-email --suppress-cc=body --to keescook@...omium.org
> > > 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch
> > > patatt: E: -: Not a valid RFC2822 message
> > > fatal: 0001-ARM-mm-proc-macros-ensure-_tlb_fns-are-4B-aligned.patch:
> > > rejected by sendemail-validate hook
> > > fatal: command 'git hook run sendemail-validate -- <patch>' died with
> > > exit code 1
> > > warning: no patches were sent
> >
> > Woah. What git version is this?
> 
> $ git --version
> git version 2.33.0.800.g4c38ced690-goog
> 
> Looks like some corporate version...anything else I can to do to help
> debug? (Moving explicit CC's to BCC).

So, this line:

> fatal: command 'git hook run sendemail-validate -- <patch>' died with exit code 1

Suggests to me that your git version is patched to carry the
new-and-not-yet-accepted "git hook" changes. It seems that it both opens a
stdin and passes the file as the parameter. When we find a stdin, we always
grab that instead of the passed parameter, but that's only a problem with this
change to git.

I'll add a fix that will always disregard stdin when we're running with
--hook.

-K