linux-kernel - Re: [PATCH] RDMA/hns: Use dma_alloc_coherent() instead of kmalloc/dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211004195224.GA2576309@nvidia.com>
Date:   Mon, 4 Oct 2021 16:52:24 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Lijun Ou <oulijun@...wei.com>, Weihang Li <liweihang@...wei.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/hns: Use dma_alloc_coherent() instead of
 kmalloc/dma_map_single()

On Mon, Sep 27, 2021 at 08:59:13AM -0300, Jason Gunthorpe wrote:
> On Sun, Sep 26, 2021 at 02:11:15PM +0800, Cai Huoqing wrote:
> > Replacing kmalloc/kfree/dma_map_single/dma_unmap_single()
> > with dma_alloc_coherent/dma_free_coherent() helps to reduce
> > code size, and simplify the code, and coherent DMA will not
> > clear the cache every time.
> > 
> > Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> >  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 20 +++++---------------
> >  1 file changed, 5 insertions(+), 15 deletions(-)
> 
> Given I don't see any dma_sync_single calls for this mapping, isn't
> this a correctness fix too?

HNS folks?

Jason