linux-kernel - Re: [PATCH 1/9] staging: vchiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Oct 2021 16:55:17 -0300
From:   Gaston Gonzalez <gascoar@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     linux-staging@...ts.linux.dev, gregkh@...uxfoundation.org,
        nsaenz@...nel.org, stefan.wahren@...e.com, arnd@...db.de,
        ojaswin98@...il.com, amarjargal16@...il.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, gascoar@...il.com
Subject: Re: [PATCH 1/9] staging: vchiq_core: cleanup blank lines

On Mon, Oct 04, 2021 at 09:55:11AM +0300, Dan Carpenter wrote:
> On Sun, Oct 03, 2021 at 04:57:51PM -0300, Gaston Gonzalez wrote:
> > Remove unnecessary blank lines.
> > 
> > Reported by checkpatch.pl
> > 
> > Signed-off-by: Gaston Gonzalez <gascoar@...il.com>
> > ---
> 
> [ snip ]
> 
> > @@ -3207,7 +3206,6 @@ enum vchiq_status vchiq_bulk_transfer(unsigned int handle,
> >  	}
> >  
> >  	state = service->state;
> > -
> >  	queue = (dir == VCHIQ_BULK_TRANSMIT) ?
> >  		&service->bulk_tx : &service->bulk_rx;
> >  
> 
> 
> I don't care one way or the other about the blank line, but it's
> not a checkpatch warning.
>

Thanks for the review Dan.

Of course you are right... This was not supposed to be here, I'm sorry.

Please drop the series, I'll a send a v2.

Thanks,

Gaston

> regards,
> dan carpenter
>