linux-kernel - Re: [PATCH 03/11] regulator: qcom-rpmh: Add PM6350 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVtvwy4egA3sEgBy@sirena.org.uk>
Date:   Mon, 4 Oct 2021 22:18:59 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Luca Weiss <luca@...tu.xyz>
Cc:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/11] regulator: qcom-rpmh: Add PM6350 regulators

On Mon, Oct 04, 2021 at 10:44:25PM +0200, Luca Weiss wrote:
> On Montag, 4. Oktober 2021 14:37:31 CEST Mark Brown wrote:

> > If you don't know don't fix it into ABI, just don't specify anything
> > until someone figures out something accurate to put in there.

> The RPMH_VREG macro expects _supply_name so what should I put there instead?

NULL should do the right thing, or make a new macro.

> > > Additionally leave out configuration of smps3 - smps5 and ldo17 as these
> > > are not configured in the downstream kernel.

> > Just describe everything that's there - nothing will get touched if the
> > board doesn't explicitly enable doing so, otherwise everything is read
> > only.

> Problem is I do not know which types those regulators are, e.g. pldo or nldo. 
> The ones I described are experimentally verified because the wrong configuration 
> makes the driver probe fail.
> So I can't really put anything there, unless there's another way to do this.

That makes sense, please explain in the commit log that only are they
not initialized but also you don't know what types they are.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)