linux-kernel - [PATCH] leds: LP50XX should select REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20211004232055.23452-1-rdunlap@infradead.org>
Date:   Mon,  4 Oct 2021 16:20:55 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Dan Murphy <dmurphy@...com>, Pavel Machek <pavel@....cz>,
        linux-leds@...r.kernel.org
Subject: [PATCH] leds: LP50XX should select REGMAP_I2C

REGMAP_I2C is not a user visible kconfig symbol so driver configs
should not "depend on" it. They should depend on I2C and then
select REGMAP_I2C.

If this worked, it was only because some other driver had set/enabled
REGMAP_I2C.

Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc: Dan Murphy <dmurphy@...com>
Cc: Pavel Machek <pavel@....cz>
Cc: linux-leds@...r.kernel.org
---
 drivers/leds/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- lnx-515-rc4.orig/drivers/leds/Kconfig
+++ lnx-515-rc4/drivers/leds/Kconfig
@@ -370,7 +370,8 @@ config LEDS_LP3952
 
 config LEDS_LP50XX
 	tristate "LED Support for TI LP5036/30/24/18/12/09 LED driver chip"
-	depends on LEDS_CLASS && REGMAP_I2C
+	depends on LEDS_CLASS && I2C
+	select REGMAP_I2C
 	depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR
 	help
 	  If you say yes here you get support for the Texas Instruments