lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Oct 2021 01:46:01 +0000 From: Billy Tsai <billy_tsai@...eedtech.com> To: Rob Herring <robh@...nel.org> CC: "lee.jones@...aro.org" <lee.jones@...aro.org>, "joel@....id.au" <joel@....id.au>, "andrew@...id.au" <andrew@...id.au>, "thierry.reding@...il.com" <thierry.reding@...il.com>, "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>, BMC-SW <BMC-SW@...eedtech.com> Subject: Re: [v9 1/2] dt-bindings: Add bindings for aspeed pwm-tach. Hi Rob, On 2021/7/14, 12:02 PM, "Billy Tsai" <billy_tsai@...eedtech.com> wrote: On 2021/7/14, 6:14 AM, "Rob Herring" <robh@...nel.org> wrote: On Fri, Jul 09, 2021 at 02:52:16PM +0800, Billy Tsai wrote: >>> This patch adds device binding for aspeed pwm-tach device which is a >>> multi-function device include pwm and tach function and pwm/tach device >>> bindings which should be the child-node of pwm-tach device. >>I'll say it again, the fan control h/w needs some common bindings for >>describing fans and fan connections to pwm and tach. I'm not going to >>sign off on more fan bindings just doing their own thing. > This patch doesn't use to binding the fan control h/w. It is used to binding the two independent h/w blocks. > One is used to provide pwm output and another is used to monitor the speed of the input. > It is different from "aspeed-pwm-tacho.txt" and "npcm750-pwm-fan.txt" which only focus on fan usage. > It is more like the "kontron,sl28cpld.yaml" the device includes a fan monitor and PWM output devices. Can you give me more suggestions about this patch? Thanks
Powered by blists - more mailing lists